Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on cradle #2169

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Remove dependency on cradle #2169

merged 2 commits into from
Jun 18, 2024

Conversation

nc7s
Copy link
Contributor

@nc7s nc7s commented Jun 18, 2024

...as an effort of minimizing dependencies in Debian. Since the tests are meant to pass, I just unwrap()'d it.

JustRun is just an improvised name, as well as its placement. Do advice if you just don't like that.

@casey
Copy link
Owner

casey commented Jun 18, 2024

Good call!

I think it's fine to just call Command instead of adding a trait, since it's only three places, it's not really a huge amount of extra code. I pushed a diff to the PR which removes JustRun and uses Command directly.

@casey casey enabled auto-merge (squash) June 18, 2024 02:40
@casey casey merged commit 71b72c4 into casey:master Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants