Fix bug in redefinition compile error reporting #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaddeo
force-pushed
the
bug/redefinition-compile-error-reporting
branch
from
67594b4
to
4910eb3
Compare
|
Nice! Can you add a test which demonstrates the fix? |
Test added 👍🏻 |
This fixes the alias_shadows_recipe_after test so that the correct results are expected. This causes the test to now fail.
The original and redefined Name's were being properly swapped, but their types weren't being swapped. This caused the error to report on the wrong lines when the redefinition was between two different types, i.e. alias and recipe. Closes casey#2350
marcaddeo
force-pushed
the
bug/redefinition-compile-error-reporting
branch
from
e95f003
to
c334201
Compare
|
Nice, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that caused the error reporting for redefinition compile errors to be reported "backwards" when the original and redefinition were differing types.
See #2350 for additional information.