Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated tempdir dependency #455

Merged
merged 4 commits into from
Jul 7, 2019
Merged

Conversation

NickeZ
Copy link
Contributor

@NickeZ NickeZ commented Jul 6, 2019

I'm trying to package just in debian and this dependency would be a blocker for that.

edit: This won't pass CI until a new release of brev has been published.

@casey
Copy link
Owner

casey commented Jul 7, 2019

I think the failure on AppVeyor is an issue with rust's use of the MinGW toolchain on Windows. I just pushed a commit changing the toolchain in the appveyor config to MSVC toolchain (with static linking to the C runtime, since we had some issues with dynamically linked binaries before), so hopefully that works.

@casey casey merged commit ff91e3d into casey:master Jul 7, 2019
@casey
Copy link
Owner

casey commented Jul 7, 2019

That fixed it. Merged, and thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants