Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository attribute in Cargo.toml #493

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Add repository attribute in Cargo.toml #493

merged 2 commits into from
Oct 13, 2019

Conversation

SOF3
Copy link
Contributor

@SOF3 SOF3 commented Oct 13, 2019

docs.rs shows the GitHub page iff package.repository is provided in Cargo.toml

Otherwise it just shows "Homepage", and doesn't display stars, issues, etc.

docs.rs shows the GitHub page iff `package.repository` is provided in Cargo.toml

Otherwise it just shows "Homepage", and doesn't display stars, issues, etc.
@casey
Copy link
Owner

casey commented Oct 13, 2019

Thank you for the PR!

Are you sure that the .git extension should be there? For example, in Cargo's Cargo.toml, the repository key is set to the GitHub URL without the .git extension.

@SOF3
Copy link
Contributor Author

SOF3 commented Oct 13, 2019

Perhaps not using the .git is better, I suppose. For GitHub though, both are equivalent, because cloning without .git will automatically redirect, and accessing repo webpage with .git will automatically redirect as well

@casey casey merged commit 6acabb2 into casey:master Oct 13, 2019
@casey
Copy link
Owner

casey commented Oct 13, 2019

Sweet, merged!

@SOF3 SOF3 deleted the patch-1 branch October 13, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants