Resolve recipe dependencies #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analyzer checks that all recipe dependencies exist, but before this diff, recipe dependencies remained names that would have to be looked up when run. This diff changes analysis to resolve recipe dependencies to actual recipes (Rc<Recipe>), to give type-level certainty that resolution was performed correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analyzer checks that all recipe dependencies exist, but before this
diff, recipe dependencies remained names that would have to be looked up
when run.
This diff changes analysis to resolve recipe dependencies to actual
recipes (
Rc<Recipe>), to give type-level certainty that resolutionwas performed correctly.
Part of #515.