Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit justfile example #639

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Add pre-commit justfile example #639

merged 2 commits into from
Jun 10, 2020

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Jun 10, 2020

closes #637

@casey
Copy link
Owner

casey commented Jun 10, 2020

Looks good! Is the 00.justfile name intentional? Can it just be Justfile?

@blaggacao
Copy link
Contributor Author

Jep it's intentional, if somebody comes along with another example, one day...
Maybe there might also be a more common topic than pre-commit where it could get denser, so I figured we should provide a non-semantic mechanism (ordinal) to account for multiple examples.

Do you think that's over-engineered?

@casey
Copy link
Owner

casey commented Jun 10, 2020

I think if there's another pre-commit example, it could go in pre-commit-foo/Justfile.

I'm actually really not sure if they should be in subdirectories at all. The reason I thought subdirectories would be good is so the actual file could be called Justfile, but it might be better to just have them be in examples, with a .just suffix, so examples/pre-commit.just, examples/automation.just, etc.

I think it's probably good to make the hierarchy more flat, and then add depth later as needed.

@blaggacao
Copy link
Contributor Author

Agree!

@casey
Copy link
Owner

casey commented Jun 10, 2020

Awesome, looks great! Thanks for this, I think example justfiles will be a great addition to the docs. Soon, I'll add a link in the readme, and also add an integration test that makes sure that example justfiles always parse correctly.

@casey casey merged commit 3ec04f3 into casey:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage example
2 participants