Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditionals #714

Merged
merged 21 commits into from
Oct 27, 2020
Merged

Add conditionals #714

merged 21 commits into from
Oct 27, 2020

Conversation

casey
Copy link
Owner

@casey casey commented Oct 26, 2020 •
edited
Loading

Todo:

  • test new error message formatting
  • make }}} parse as } }}
  • document that it short-circuits
  • document that it can be used inside and outside of interpolations
  • document that you can use == and !=

@casey
[WIP] Add if/else conditional expressions
47a188c
@casey
Test lexer
c16f7e3
@casey
Test conditional trees
48c723e
@casey
Test conditional branch evaluation
45de1c7
@casey
Remove completed TODO
89963f1
@casey
Test that variables are evaluated in all branches
7ff1776
@casey
Test conditional with more complex expressions
35a6da4
@casey
More tests
4625ca3
@casey
Formatting
fef95e4
@casey
Delete TODOs
2ecd2b5
@casey
Fix summary
8a20f2d
@casey
Fix
eff8aed
@casey
Use presume
4fb54ec
@casey
Misc
8488716 
- Don't parse interpolation start and end outside of interpol
- remove hacky extra space
- use and test Lexer::presume
@casey
Actually, always parse }} in interpolation as close interpolation
1fc4399 
It's easier to work around this way.
@casey
Test error messages
049f562
@casey
Document conditionals
915f7a3
@casey
Quote special characters
4082509
@casey
Use kebab case for keywords
f55f8ed
@casey
Refactor lex_cr_lf
7f4e722
@casey
Rename lexer tests
406baa6
@casey casey merged commit 19f7ad0 into master Oct 27, 2020
@casey casey deleted the conditional branch October 27, 2020 01:16
@casey casey mentioned this pull request Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@casey