Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to GitHub Action #729

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Add link to GitHub Action #729

merged 1 commit into from
Nov 27, 2020

Conversation

rossmacarthur
Copy link
Contributor

Just wanted to share the GitHub Action I wrote to install just. I use just regularly as a command runner in my projects and often want to run it in CI. See extractions/setup-just.

@casey
Copy link
Owner

casey commented Nov 26, 2020

This is awesome!

For the readme, what do you think about:

=== GitHub Actions

link:https://github.com/extractions/setup-just[extractions/setup-just] can be used to install `just` in a GitHub Actions workflow.

Example usage:

```yaml
- uses: extractions/setup-just@v1
  with:
    just-version: 0.8  # optional semver specification, otherwise latest
```

@casey
Copy link
Owner

casey commented Nov 26, 2020

Is "semver specification" the word for a semver requirement specifier, i.e. "^0.5.0"?

I was trying to figure out what people call it most frequently, but nothing stood out. It seems like, in practice, people don't distinguish between a semantic version, e.g. 0.5.0, and a npm-style semver specifier, i.e ^0.5.0.

In any case, semver specification is fine.

@rossmacarthur
Copy link
Contributor Author

rossmacarthur commented Nov 27, 2020

Happy with your requested changes to the text, I have updated the branch.

Yes, it is a semver requirement specifier. I'm using this package in the GitHub Action: https://www.npmjs.com/package/semver. This package resolves plain versions slightly differently to Cargo though where 0.5.0 is equivalent to =0.5.0 not ^0.5.0.

@casey casey merged commit d43241a into casey:master Nov 27, 2020
@casey
Copy link
Owner

casey commented Nov 27, 2020

Awesome, merged.

You might consider documenting in the action's readme that it's an npm-style semver spec. Just users are pretty varied, but I think a good chunk of them are Rust users, and they might be confused by the difference.

Thanks so much for writing and documenting this, I think it's a really nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants