Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null island bug (support for 0,0 co-ordinates) #12

Merged
merged 1 commit into from
May 6, 2015

Conversation

missinglink
Copy link
Contributor

support for 0,0 co-ordinates

GeoJSON.parse([{ lat: 0, lng: 0 }], {Point: ['lat', 'lng']}, function(geojson){
  console.log( JSON.stringify( geojson, null, 2 ) );
});

before:

{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "geometry": {},
      "properties": {}
    }
  ]
}

after:

{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "geometry": {
        "type": "Point",
        "coordinates": [
          0,
          0
        ]
      },
      "properties": {}
    }
  ]
}

@caseycesari
Copy link
Owner

Thanks. Looks good. Do you mind rebasing on master and removing the merge commit? I'll merge this then publish a new release.

@missinglink
Copy link
Contributor Author

heya @caseypt how does that look now?

...also I didn't know how to regenerate the minified version, would you be able to cut a new one?

@caseycesari
Copy link
Owner

Thanks! Yeah, I'll take care of it.

caseycesari pushed a commit that referenced this pull request May 6, 2015
Null island bug (support for 0,0 co-ordinates)
@caseycesari caseycesari merged commit 6288755 into caseycesari:master May 6, 2015
@caseycesari
Copy link
Owner

Publish v0.2.1 to npm

@missinglink
Copy link
Contributor Author

awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants