Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added carthage support for accessibility core #131

Merged
merged 6 commits into from
Aug 10, 2023

Conversation

a-25
Copy link
Contributor

@a-25 a-25 commented Jul 17, 2023

Added Carthage support for AccessibilitySnapshotCore framework.
Closes #130

@a-25 a-25 mentioned this pull request Jul 17, 2023
@NickEntin
Copy link
Collaborator

Thanks for adding this @a-25! Can we add a CI job to build this? I want to make sure this doesn't regress, especially as Carthage isn't used for the sample project or other CI jobs.

@a-25
Copy link
Contributor Author

a-25 commented Aug 8, 2023

Hello @NickEntin .
I added a job, could I do anything to check it? Seems like it should run any time when others do but I cannot see it in the list.

Copy link
Collaborator

@NickEntin NickEntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @a-25! I got the CI job added so it will run now. One comment about adding the license to the header and we're good. I'll go ahead and merge it.

@NickEntin NickEntin merged commit 5eff4aa into cashapp:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Carthage support
2 participants