Add German and Russian locales to demo app #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listing these as supported locales and adding the associated schemes makes it easier to run the demo app to get the translated strings from VoiceOver.
NickEntin
requested review from
RoyalPineapple,
meherkasam,
luispadron and
kruegermj
meherkasam
approved these changes
Jan 28, 2024
|
@meherkasam I'm not proactively adding more languages right now, but happy to add more languages as they're requested by developers. Each one adds some overhead work to making updates, so I don't want to add languages that consumers don't actually need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listing these as supported locales and adding the associated schemes makes it easier to run the demo app to get the translated strings from VoiceOver.