-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate strings to Russian #88
Conversation
Hey @akaDuality, thanks for your interest in AccessibilitySnapshot! If you look at the "Data Table" screen in the sample app, the B3 cell spans 2 rows. @jhneves Mind taking a look at the conversion to stringsdict? |
@akaDuality yes it's fine to update to |
Thank you, I'll add |
bef21dc
to
fb94b63
Compare
I've understand that there is no need in plurals right now. English version can't "span 1 row" and Russian version has format that avoids plurals at all. I updated localisation and all strings are correct now and can be merged. |
@akaDuality sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, left some suggestions.
Sources/AccessibilitySnapshot/Core/Swift/Assets/ru.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Assets/ru.lproj/Localizable.strings
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Assets/ru.lproj/Localizable.strings
Show resolved
Hide resolved
Sources/AccessibilitySnapshot/Core/Swift/Assets/ru.lproj/Localizable.strings
Show resolved
Hide resolved
Add Change localization
fb94b63
to
d47b89a
Compare
@akaDuality looks great, one last step to contribute is to sign here, please take a look and let me know. |
@jhneves Done! |
Thank you @akaDuality ! |
Thank you for approving! Do you have any plans on release? |
we're working on that @akaDuality, should be out very soon. |
We are going to use the library in our application and would like to translate text to Russian.
I have two questions: