Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate strings to Russian #88

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

akaDuality
Copy link
Contributor

We are going to use the library in our application and would like to translate text to Russian.

I have two questions:

  • In which application I can see example of table's height that pronounce "Span 3 rows"
  • Can I create .strignsdict to translate plurals correctly? In this case I need help with German translation

@NickEntin
Copy link
Collaborator

NickEntin commented May 24, 2022

Hey @akaDuality, thanks for your interest in AccessibilitySnapshot! If you look at the "Data Table" screen in the sample app, the B3 cell spans 2 rows.

@jhneves Mind taking a look at the conversion to stringsdict?

@jhneves
Copy link
Collaborator

jhneves commented May 25, 2022

@akaDuality yes it's fine to update to .stringsdict, I will find out someone to help with the German translation.

@akaDuality
Copy link
Contributor Author

akaDuality commented May 26, 2022

Thank you, I'll add .stringsdict to this PR in a few days

@akaDuality akaDuality force-pushed the russianLocalization branch from bef21dc to fb94b63 Compare May 28, 2022 12:08
@akaDuality
Copy link
Contributor Author

I've understand that there is no need in plurals right now. English version can't "span 1 row" and Russian version has format that avoids plurals at all.

I updated localisation and all strings are correct now and can be merged.

@jhneves
Copy link
Collaborator

jhneves commented Jun 1, 2022

@akaDuality sounds good!

Copy link
Collaborator

@AliceAponasko AliceAponasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, left some suggestions.

Add

Change localization
@akaDuality akaDuality force-pushed the russianLocalization branch from fb94b63 to d47b89a Compare June 4, 2022 11:31
@jhneves
Copy link
Collaborator

jhneves commented Jun 7, 2022

@akaDuality looks great, one last step to contribute is to sign here, please take a look and let me know.

@akaDuality
Copy link
Contributor Author

@jhneves Done!

@jhneves jhneves merged commit 146b9f8 into cashapp:master Jun 9, 2022
@jhneves
Copy link
Collaborator

jhneves commented Jun 9, 2022

Thank you @akaDuality !

@akaDuality
Copy link
Contributor Author

Thank you for approving!

Do you have any plans on release?

@jhneves
Copy link
Collaborator

jhneves commented Jun 24, 2022

we're working on that @akaDuality, should be out very soon.

@akaDuality akaDuality deleted the russianLocalization branch June 25, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants