Moving Package Variable to Monitor #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the package-level variables `statusQuery` and `newTerms` to the monitor in case multiple monitors within the same domain are created but are running on different MySQL versions. Added a check around `replStatus` when getting the "source" entry. In cases where something is not a replica the map will be nil and should not be accessed.
| @@ -86,9 +90,6 @@ func (c *Repl) Help() blip.CollectorHelp { | |||
| } | |||
| } | |||
|
|
|||
| var statusQuery = "SHOW SLAVE STATUS" // SHOW REPLICA STATUS as of 8.022 | |||
There was a problem hiding this comment.
Please put that comment back, i.e. (few lines up in the diff):
statusQuery: "SHOW SLAVE STATUS", // SHOW REPLICA STATUS as of 8.022When working with MySQL, you'll find that such "as of " comments are common and helpful, especially when your career with MySQL begins to span decades. Lots and lots of changes, and who can remember them all?
daniel-nichter
approved these changes
Feb 1, 2023
Adding version comment back in
Areson
added a commit
that referenced
this pull request
Feb 1, 2023
Related to #93 Updated unit tests, as now that compression is _actually_ working the client compresses the data for us in the unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the package-level variables
statusQueryandnewTermsto the monitor in case multiple monitors within the same domain are created but are running on different MySQL versions.Added a check around
replStatuswhen getting the "source" entry. In cases where something is not a replica the map will be nil and should not be accessed.