Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to use the regular Assembly type in Knit #177

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

skorulis-ap
Copy link
Collaborator

@skorulis-ap skorulis-ap commented Jul 17, 2024

The ability to use other assemblies isn't something that ever got used so I'm taking it out. I don't think this is a particular issue for performance but less code means less places for performance issues to hide.

@skorulis-ap skorulis-ap marked this pull request as ready for review July 17, 2024 10:40
@skorulis-ap skorulis-ap requested a review from bradfol July 17, 2024 10:40
@skorulis-ap skorulis-ap merged commit 0ef4f36 into main Jul 17, 2024
1 check passed
@skorulis-ap skorulis-ap deleted the skorulis/non-module-assembly branch July 17, 2024 21:00
@bradfol bradfol mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants