Do not log empty line when unused warnings are not logged (#296)

* Do not log empty line when unused warnings are not logged * Apply suggestions from code review --------- Co-authored-by: Jake Wharton <github@jakewharton.com>
cashapp · Feb 12, 2024 · 775827c · 775827c
1 parent 4424b26
commit 775827c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/main/kotlin/app/cash/licensee/task.kt b/src/main/kotlin/app/cash/licensee/task.kt
@@ -308,7 +308,9 @@ abstract class LicenseeTask : DefaultTask() {
     if (validationResult.configResults.isNotEmpty() && validationResult.artifactResults.isNotEmpty()) {
       validationReport.appendLine()
       // We know these are always at warning or error level, so use lifecycle for space.
-      logger.log(lifecycleLevel, "")
+      if (unusedWarningLevel > INFO || unusedErrorLevel > INFO || logger.isInfoEnabled) {
+        logger.log(lifecycleLevel, "")
+      }
     }
     for ((artifactDetail, results) in validationResult.artifactResults) {
       val coordinateHeader = buildString {

diff --git a/src/test/kotlin/app/cash/licensee/LicenseePluginFixtureTest.kt b/src/test/kotlin/app/cash/licensee/LicenseePluginFixtureTest.kt
@@ -263,6 +263,7 @@ class LicenseePluginFixtureTest {
       |WARNING: Allowed .*? is unused
       """.trimMargin(),
     )
+    assertThat(result.output).doesNotContain("\n\n> Task :licensee")
   }
 
   @Test fun unusedWarn(