-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning allowed dependency is unused in KMP Project #64
Comments
I'm out the rest of the year. This will have to be tackled next year at some point. |
Probably covered by #48, too. |
Another solution proposal to mention is adding warning suppression options. Something like this: licensee {
allow("Apache-2.0")
warnings {
unusedAllowedIdentifiers = false
unusedAllowedUrls = false
unusedAllowedCoordinates = false
}
} |
I've made a proof of concept of such API: vdshb@304f273 Works perfect for me. It is for 1.7.0, because I need it for projects with previous AGP. @JakeWharton Let me know if you interested in this peace of functionality. I'll try to make a proper PR(s) for 1.8.x/1.7.x. |
You can hide warnings now with #285. To be released next week. |
Works for me; hence closing this. |
When I run the aggregation task
licensee
all of the tasks for each applicable plugin are ran. Since the configuration is shared there are some warnings:Obviously,
jvm
does not needios
targeted dependencies.In my project where I have a common module that's being used on Android, iOS & Server I get 96 of those warnings.
Not only is that a lot, actually removing a custom URL / license becomes impossible since I'd need to try it out, rerun everything.
Since the warnings come from the fine grained task, I guess the one solution would be to have custom logic inside
licensee
which does it's own validation without delegating to other tasks.Another solution would be to have different configurations for each target.
The text was updated successfully, but these errors were encountered: