Add configuration to disable unused license warnings #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Jan 16, 2024
|
Just tried running the build on my fork, seems to be setting up Java okay: https://github.com/jonapoul/licensee/actions/runs/7547641594 |
|
Yeah I retried a few times already. I'll try again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put this together because I had a similar use case to some of the people in #134. Basically we have a list of allowed licenses in our organisation, so in our case it doesn't make sense to have a log full of warnings when there's no problem to flag up. Much simpler to configure the project with the licenses that we can use, then only get notified of any violations of that list.
Core of the change is a new method to the
LicenseeExtension:licensee { unusedAction(UnusedAction.IGNORE) // or WARN }where the default is
UnusedAction.WARN. Most of the diffs are test fixtures, I haven't done a whole lot of Gradle plugin tests before so let me know whether these are decent.