Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure fallback IDs are always valid #250

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Ensure fallback IDs are always valid #250

merged 1 commit into from
Sep 26, 2023

Conversation

JakeWharton
Copy link
Collaborator

Eagerly look up their associated license info so that invalid configurations fail at initialization time. Add a test to ensure initialization always happens during development.

Closes #224

@JakeWharton
Copy link
Collaborator Author 

java.lang.AssertionError: No SPDX identifier 'EPL-2.01' in the embedded set
	at app.cash.licensee.LicensesFallbackKt.putLicense(licensesFallback.kt:103)
	at app.cash.licensee.LicensesFallbackKt.<clinit>(licensesFallback.kt:89)
	at app.cash.licensee.SpdxLicensesTest.fallbackDatabaseLitmusTest(SpdxLicensesTest.kt:33)

@JakeWharton
Ensure fallback IDs are always valid
0bcfd72 
Eagerly look up their associated license info so that invalid configurations fail at initialization time. Add a test to ensure initialization always happens during development.
@JakeWharton JakeWharton force-pushed the jw.fallback-safety.2023-09-26 branch from e0f3774 to 0bcfd72 Compare September 26, 2023 14:23
Base automatically changed from jw.version.2023-09-25 to trunk September 26, 2023 15:24
@JakeWharton JakeWharton merged commit a2ede89 into trunk Sep 26, 2023
2 checks passed
@JakeWharton JakeWharton deleted the jw.fallback-safety.2023-09-26 branch September 26, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattprecious mattprecious mattprecious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A non-null fallback ID should always match a valid SPDX identifier
2 participants
@JakeWharton @mattprecious