Implement FakeFixture in FakeClusterWeight for misk test

injector reuse GitOrigin-RevId: 7c739eecbde38ee4220e539a4c2f7dc3fe63b3a7
cashapp · Nov 27, 2024 · 60cfef6 · 60cfef6
1 parent 335658e
commit 60cfef6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/misk-clustering/api/misk-clustering.api b/misk-clustering/api/misk-clustering.api
@@ -223,7 +223,7 @@ public abstract interface class misk/clustering/weights/ClusterWeightProvider {
 public abstract interface class misk/clustering/weights/ClusterWeightService : com/google/common/util/concurrent/Service {
 }
 
-public final class misk/clustering/weights/FakeClusterWeight : misk/clustering/weights/ClusterWeightProvider {
+public final class misk/clustering/weights/FakeClusterWeight : misk/testing/FakeFixture, misk/clustering/weights/ClusterWeightProvider {
 	public fun <init> ()V
 	public fun get ()I
 	public final fun setClusterWeight (I)V

diff --git a/misk-clustering/build.gradle.kts b/misk-clustering/build.gradle.kts
@@ -22,7 +22,7 @@ dependencies {
   implementation(project(":misk-backoff"))
   implementation(project(":misk-lease"))
   implementation(project(":misk-service"))
-  implementation(project(":misk-testing-api"))
+  api(project(":misk-testing-api"))
 
   testImplementation(libs.assertj)
   testImplementation(libs.junitApi)

diff --git a/misk-clustering/src/main/kotlin/misk/clustering/weights/FakeClusterWeight.kt b/misk-clustering/src/main/kotlin/misk/clustering/weights/FakeClusterWeight.kt
@@ -1,13 +1,15 @@
 package misk.clustering.weights
 
 import misk.inject.KAbstractModule
+import misk.testing.FakeFixture
+import misk.testing.TestFixture
 
 /**
  * A [ClusterWeightProvider] for testing
  */
-class FakeClusterWeight : ClusterWeightProvider {
+class FakeClusterWeight : ClusterWeightProvider, FakeFixture() {
 
-  private var weight = 100
+  private var weight by resettable { 100 }
 
   override fun get(): Int {
     return weight
@@ -25,6 +27,7 @@ class FakeClusterWeightModule : KAbstractModule() {
   override fun configure() {
     val fake = FakeClusterWeight()
     bind<FakeClusterWeight>().toInstance(fake)
+    multibind<TestFixture>().to<FakeClusterWeight>()
     bind<ClusterWeightProvider>().toInstance(fake)
     install(NoOpClusterWeightServiceModule())
   }