Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to formatting to prepare for KtLint 1.0 #1183

Closed
wants to merge 15 commits into from
Closed

Minor fixes to formatting to prepare for KtLint 1.0 #1183

wants to merge 15 commits into from

Commits on Dec 10, 2023

  1. Sync up spotless.kotlin.ktlint config overrides with .editorconfig an… 

    …d use a single source of truth.
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    9c14f18 View commit details
    Browse the repository at this point in the history

  2. Help IDEA indent correctly when user has tabs enabled.

    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    06d4137 View commit details
    Browse the repository at this point in the history

  3. > Task :sample:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\main\java\app\cash\paparazzi\sample\ResourcesDemo.kt':
Error on line: 31, column: 5
rule: standard:function-naming
Function name should start with a lowercase letter (except factory methods) and use camel case
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    3d27a62 View commit details
    Browse the repository at this point in the history

  4. > Task :sample:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\main\java\app\cash\paparazzi\sample\ResourcesDemo.kt':
Error on line: 27, column: 11
rule: standard:property-naming
Property name should use the screaming snake case notation when the value can not be changed
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    704857d View commit details
    Browse the repository at this point in the history

  5. > Task :sample:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\test\java\app\cash\paparazzi\sample\ComposeA11yTest.kt':
Error on line: 56, column: 39
rule: standard:discouraged-comment-location
A comment in a 'value_argument_list' is only allowed when placed on a separate line
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    163dadc View commit details
    Browse the repository at this point in the history

  6. > Task :paparazzi:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\main\java\app\cash\paparazzi\internal\interceptors\MatrixMatrixMultiplicationInterceptor.kt':
Error on line: 19, column: 11
rule: standard:property-naming
Property name should start with a lowercase letter and use camel case
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    42695ef View commit details
    Browse the repository at this point in the history

  7. > Task :paparazzi:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\main\java\app\cash\paparazzi\internal\resources\Pseudolocalizer.kt':
Error on line: 351, column: 15
rule: standard:property-naming
Property name should start with a lowercase letter and use camel case
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    e4ce6f0 View commit details
    Browse the repository at this point in the history

  8. > Task :paparazzi:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\main\java\app\cash\paparazzi\internal\resources\RepositoryLoader.kt':
Error on line: 124, column: 15
rule: standard:property-naming
Property name should start with a lowercase letter and use camel case
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    75f002a View commit details
    Browse the repository at this point in the history

  9. > Task :paparazzi:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\main\java\app\cash\paparazzi\internal\interceptors\MatrixVectorMultiplicationInterceptor.kt':
Error on line: 23, column: 2
rule: standard:max-line-length
Exceeded max line length (140)
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    46fabf2 View commit details
    Browse the repository at this point in the history

  10. > Task :paparazzi:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\main\java\app\cash\paparazzi\internal\resources\Pseudolocalizer.kt':
Error on line: 22, column: 1
rule: standard:no-consecutive-comments
an EOL comment may not be preceded by a KDoc. Reversed order is allowed though when separated by a newline.
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    91bcd22 View commit details
    Browse the repository at this point in the history

  11. > Task :paparazzi:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\test\java\app\cash\paparazzi\internal\resources\PseudolocaleGeneratorTest.kt':
Error on line: 85, column: 1
rule: standard:max-line-length
Exceeded max line length (140)
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    7cc86a8 View commit details
    Browse the repository at this point in the history

  12. > Task :paparazzi:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\main\java\app\cash\paparazzi\internal\interceptors\MatrixMatrixMultiplicationInterceptor.kt':
Error on line: 38, column: 15
rule: standard:function-naming
Function name should start with a lowercase letter (except factory methods) and use camel case
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    219c1de View commit details
    Browse the repository at this point in the history

  13. > Task :paparazzi-gradle-plugin:spotlessKotlin FAILED 

    Step 'ktlint' found problem in 'src\test\projects\lifecycle-usages\src\test\java\app\cash\paparazzi\plugin\test\LifecycleUsageTest.kt':
Error on line: 21, column: 13
rule: standard:function-naming
Function name should start with a lowercase letter (except factory methods) and use camel case
    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    a37bd9e View commit details
    Browse the repository at this point in the history

  14. Move comment to relevant block to prevent pinterest/ktlint#2427

    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    408a90d View commit details
    Browse the repository at this point in the history

  15. partial gradlew spotlessApply

    @TWiStErRob
    TWiStErRob committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    6025f33 View commit details
    Browse the repository at this point in the history