Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task inputs for resources and assets to account for file renames and moves #1226

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

jrodbx
Copy link
Collaborator

@jrodbx jrodbx commented Jan 13, 2024

PathSensitivity.NONE implies that no part of the path matters -- not even the filename -- so it only looks at the content which is wrong since resource IDs are usually computed from filename. In addition, if a resource is moved between qualifier folders, this would be undetected as it's considered UP-TO-DATE.

Adds additional test projects for verifying changes to:

  • local resources/assets (src/main/debug, etc.)
  • module resources/assets (:producer, etc.)
  • external resources/assets (group:artifact:version, etc.)

Copy link
Collaborator

@gamepro65 gamepro65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, love the test coverage

@jrodbx jrodbx merged commit 23f0dcd into master Jan 13, 2024
14 checks passed
@jrodbx jrodbx deleted the jrod/2023-08-30/resources-test-inputs branch January 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants