Add .gitattributes to make spotlessApply work on Windows #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Jan 19, 2023
TWiStErRob
commented
Jan 19, 2023
.gitattributes
Outdated
| # Gradle files | ||
| *.gradle text eol=lf | ||
| *.properties text eol=lf | ||
| *.bat text eol=crlf |
There was a problem hiding this comment.
Something is fishy still, even after resetting gradlew.bat keeps changing, any ideas welcome.
I tried autocrlf=true and false, and then reset, but no luck.
There was a problem hiding this comment.
Re-cloned and all good, but I was able to reproduce it with the code here: https://stackoverflow.com/q/48642692/253468
This however fixes it: https://stackoverflow.com/a/19588910/253468
Right now it's above my git abilities, but it should be fine considering retrofit uses the same file.
There was a problem hiding this comment.
It was solved in: #721
JakeWharton
reviewed
Jan 19, 2023
…ng the "all" distribution anymore." This reverts commit 670b86f.
jrodbx
approved these changes
Jan 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original behavior:
gradlew spotlessApply-> all files changedSteps:
New behavior: If I run spotless again, it changes nothing, unless there's actually something wrong.
Please someone on Mac/linux check out the branch test this (on an existing and a new clone):
paparazzi/paparazzi-gradle-plugin/src/main/kotlingit status(observe changed file)./gradlew -p paparazzi spotlessApplygit status(observe no changed files)