Unify multiplatform targets into named groups #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is like half of what I actually want to build but I'm sick of waffling so this is a small step in that direction. |
This gives us more control over what targets are built for which parts of the codebase based on their type.
The big change is the drop of MacOS targets which were wholly unused. They will likely return at some point, along with new targets for common modules as well as for Compose UI, and this new grouping will make that easy to do.
Before:
$ gw build --dry-run | grep -c SKIPPED
7469
After:
$ gw build --dry-run | grep -c SKIPPED
6405
JakeWharton
force-pushed
the
jw.targets.2024-05-31
branch
from
fb5907c
to
0ece9ed
Compare
colinrtwhite
pushed a commit
that referenced
this pull request
Jun 4, 2024
This gives us more control over what targets are built for which parts of the codebase based on their type.
The big change is the drop of MacOS targets which were wholly unused. They will likely return at some point, along with new targets for common modules as well as for Compose UI, and this new grouping will make that easy to do.
Before:
$ gw build --dry-run | grep -c SKIPPED
7469
After:
$ gw build --dry-run | grep -c SKIPPED
6405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us more control over what targets are built for which parts of the codebase based on their type.
The big change is the drop of MacOS targets which were wholly unused. They will likely return at some point, along with new targets for common modules as well as for Compose UI, and this new grouping will make that easy to do.
Before:
After:
Refs #361
CHANGELOG.md's "Unreleased" section has been updated, if applicable.