FastProtocolBridge #2106
Merged
FastProtocolBridge #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Jun 12, 2024
| private lateinit var changesSinkService: ChangesSinkService | ||
| private lateinit var sendChanges: (service: ChangesSinkService, args: List<*>) -> Any? | ||
|
|
||
| public override val widgetSystem: WidgetSystem<Unit> = |
There was a problem hiding this comment.
Too much duplication here!
JakeWharton
approved these changes
Jun 13, 2024
JakeWharton
reviewed
Jun 13, 2024
| ): ProtocolBridge = FastProtocolBridge(json, hostVersion, widgetSystemFactory, mismatchHandler) | ||
|
|
||
| @OptIn(RedwoodCodegenApi::class) | ||
| private class FastProtocolBridge( |
There was a problem hiding this comment.
I super dislike this name, but I super don't care when private!
swankjesse
force-pushed
the
jwilson.0612.fast_bridge
branch
from
61deed6
to
477ba9f
Compare
swankjesse
commented
Jun 14, 2024
| * Confirm that [FastProtocolBridge] behaves the same as [DefaultProtocolBridge]. | ||
| */ | ||
| @OptIn(ExperimentalSerializationApi::class, RedwoodCodegenApi::class) | ||
| class FastProtocolBridgeTest { |
There was a problem hiding this comment.
FYI @JakeWharton this is new!
| id: Id, | ||
| tag: PropertyTag, | ||
| value: UInt, | ||
| ) |
There was a problem hiding this comment.
This is new! And it’s quite unfortunate!
I don’t think we need to implement something general purpose for other kotlinx.serialization types. UInt is something we’re already using in Cash App, so we’re pinned here.
This is a new implementation of ProtocolBridge that uses Zipline's new asDynamicFunction() API. It's dramatically faster - in one measurement we went from spending ~18% of our samples on serialization to ~3% of our samples.
swankjesse
force-pushed
the
jwilson.0612.fast_bridge
branch
from
81c5a56
to
7587680
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new implementation of ProtocolBridge that uses Zipline's new asDynamicFunction() API. It's dramatically faster - in one measurement we went from spending ~18% of our samples on serialization to ~3% of our samples.