Alter table add constraint check (#4120)

* Alter table add constraint check for MySql Dialect Update mysql grammer support for table add constraint check uses inherited check_constraint expression * Alter table add constraint check for MySql Dialect Add test fixture * Alter table add constraint check for PostgreSql Dialect Add test fixture * Alter table add constraint check for PostgreSql Dialect Update postgressql grammer support for table add constraint check uses inherited check_constraint expression
cashapp · Apr 28, 2023 · c8784ac · c8784ac
1 parent 149bad6
commit c8784ac
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/dialects/mysql/src/main/kotlin/app/cash/sqldelight/dialects/mysql/grammar/MySql.bnf b/dialects/mysql/src/main/kotlin/app/cash/sqldelight/dialects/mysql/grammar/MySql.bnf
@@ -119,7 +119,7 @@ bind_parameter ::= DEFAULT | ( '?' | ':' {identifier} ) {
 }
 table_constraint ::= [ CONSTRAINT {identifier} ] (
   ( PRIMARY KEY | [ UNIQUE | 'FULLTEXT' ] KEY | [ UNIQUE | 'FULLTEXT' ] [ INDEX ] ) [{index_name}] LP {indexed_column} [ LP {signed_number} RP ] ( COMMA {indexed_column} [ LP {signed_number} RP ] ) * RP {conflict_clause} [comment_type] |
-  CHECK LP expr RP |
+  {check_constraint} |
   FOREIGN KEY LP {column_name} ( COMMA {column_name} ) * RP {foreign_key_clause}
 ) {
   extends = "com.alecstrong.sql.psi.core.psi.impl.SqlTableConstraintImpl"

diff --git a/dialects/mysql/src/test/fixtures_mysql/alter-table-add-constraint-check/1.s b/dialects/mysql/src/test/fixtures_mysql/alter-table-add-constraint-check/1.s
@@ -0,0 +1,6 @@
+CREATE TABLE t1 (
+  c1 int(11)
+);
+
+ALTER TABLE t1
+ ADD CONSTRAINT chk_c1 CHECK (c1 > 0);
diff --git a/...postgresql/src/main/kotlin/app/cash/sqldelight/dialects/postgresql/grammar/PostgreSql.bnf b/...postgresql/src/main/kotlin/app/cash/sqldelight/dialects/postgresql/grammar/PostgreSql.bnf
@@ -121,6 +121,7 @@ bind_parameter ::= DEFAULT | ( '?' | ':' {identifier} ) {
 }
 table_constraint ::= [ CONSTRAINT {identifier} ] (
   ( PRIMARY KEY | UNIQUE ) [{index_name}] LP {indexed_column} [ LP {signed_number} RP ] ( COMMA {indexed_column} [ LP {signed_number} RP ] ) * RP {conflict_clause} [comment_type] |
+  {check_constraint} |
   FOREIGN KEY LP {column_name} ( COMMA {column_name} ) * RP {foreign_key_clause}
 ) {
   extends = "com.alecstrong.sql.psi.core.psi.impl.SqlTableConstraintImpl"

diff --git a/dialects/postgresql/src/test/fixtures_postgresql/alter-table-add-constraint-check/1.s b/dialects/postgresql/src/test/fixtures_postgresql/alter-table-add-constraint-check/1.s
@@ -0,0 +1,6 @@
+CREATE TABLE t1 (
+  c1 INTEGER
+);
+
+ALTER TABLE t1
+ ADD CONSTRAINT chk_c1 CHECK (c1 > 0);