-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated code is using full qualifier names #1939
Comments
the problem here is that the |
@AlecStrong are you some kind of robot? 🙃 |
haha i had a hunch what the fix would be, once thats merged try the snapshot and let me know if its still broken |
Where is hosted the snapshot? Didn't find on the website |
True the documentation for that is no longer on the site, I added that back here: #1941 once the pull request to fix this issue is merged a snapshot will be published ~30min after that, then you can depend on it by doing buildscript {
repositories {
maven {
url "https://oss.sonatype.org/content/repositories/snapshots/"
}
}
dependencies {
classpath "com.squareup.sqldelight:gradle-plugin:1.5.0-SNAPSHOT"
}
} |
Thank you, I'll keep an eye on it! |
Just a note, don't wanna bother with a new issues, unless I should 🙂 : probably is there temporally as is a snapshot version or maybe it is intentional, dunno about the policies, but there is an import from an import com.squareup.sqldelight.internal.copyOnWriteList |
i think thats fine, its just intended to to say "this should only be used by sqldelight-generated code" |
Intentional. For use by generated code only. |
yes, it will use the FQN if there is a collision |
Build Environment
SQLDelight version: 1.4.3
OS: MacOS Big Sur beta
Gradle version: 6.6-rc-6-all
Kotlin version: 1.4.0
Describe the bug
Generated code does use full qualifier names and this clashes with my
database.*
package.I have my sq files in
database/src/commonMain/sqldelight/database/*
Gradle configured as following
I've used this setup on SqlDelight
1.4.0
and1.4.1
and there was no error as it was generating something likeBut now it's generating something like:
that clashes with
private val database: DatabaseImpl
, while it should be as following, since the correct import is already thereThe text was updated successfully, but these errors were encountered: