Problem compiling upsert statement

[Zlash92]

SQLDelight Version

1.5.3

Operating System

macOS Big Sur 11.6.2

Gradle Version

7.3.1

Kotlin Version

1.6.0

AGP Version

No response

Describe the Bug

I'm trying to implement the upsert query using postgres. Here's a simple example (I also tried using a grouped statement, but in postgres this operation can be done in one statement):

upsert:
INSERT INTO pld1.Person (id, name, age)
VALUES (:id, :name, :age)
ON CONFLICT(id) DO UPDATE SET id = :id, name = :name, age = :age;

However, compilation fails unless exactly two fields are updated in the query. The stacktrace shows the error I get trying to update all three fields in the table. I get the same error when only the id is updated in the query. When the query contains two fields, it compiles and works as expected.

Stacktrace

line 15:52 - <binary like operator real>, <column name real>, BETWEEN, IN or RETURNING expected, got ','
13    INSERT INTO pld1.Person (id, name, age)
14    VALUES (:id, :name, :age)
15    ON CONFLICT(id) DO UPDATE SET id = :id, name = :name, age = :age
                                                          ^


Execution failed for task ':generateMainTestDatabaseInterface'.
> A failure occurred while executing com.squareup.sqldelight.gradle.SqlDelightTask$GenerateInterfaces
   > Generation failed; see the generator error output for details.

Gradle Build Script

No response

[Satook]

Happy to make a PR but I'm unsure if the cause is the grouping of the statements or the priority pinning of the trailing (column = expr) pairs.

I wasn't able to reproduce with tests in sql-psi alone. It seems to be something about the way the grammar/parser is constructed within SQLDelight.

[AlecKazakova]

are you able to create a failing test in the sqldelight-compiler tests? That would be a good place to start

[Satook]

I'll give it a go. Thanks for the hint 😄 !