Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux targets for app.cash.sqldelight:androidx-paging3-extensions #4272

Closed
chippmann opened this issue Jun 13, 2023 · 3 comments · Fixed by #4280
Closed

Add linux targets for app.cash.sqldelight:androidx-paging3-extensions #4272

chippmann opened this issue Jun 13, 2023 · 3 comments · Fixed by #4280
Labels

Comments

@chippmann
Copy link
Contributor

SQLDelight Version

2.0.0-rc01

Operating System

linux

Gradle Version

7.6

Kotlin Version

1.8.21

Dialect

sqlite-3-18-dialect

AGP Version

7.3.1

Describe the Bug

Currently there is no linux target (or any native target other than iOS and macOS) defined in the paging build.gradle and thus none of them are published to maven

Stacktrace

No response

Gradle Build Script

No response

@chippmann chippmann added the bug label Jun 13, 2023
@chippmann
Copy link
Contributor Author

chippmann commented Jun 13, 2023

If you want (and no other tackles this issue in the meantime) I'll look into this and submit a PR for it later this week.

Edit: just realized that the "upstream" project https://github.com/cashapp/multiplatform-paging does not define them as well. Is there a reason for that (other than maybe time?)

@JakeWharton
Copy link
Collaborator

cc @veyndan

@chippmann
Copy link
Contributor Author

Just created a PR over at cashapp/multiplatform-paging#121.
Once that one (or something similar) is merged and published, I could create a follow up PR here if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants