Add linux and mingw target #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d mingw runner and mingw target
veyndan
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Awesome, thanks! Usually a change to the respective androidx-main-XYZ branch would be required, but as we're just symlinking the file contents, and adding these targets require zero code changes to the aforementioned branch, we can safely skip this step.
chippmann
added a commit
to chippmann/sqldelight
that referenced
this pull request
Jun 15, 2023
**Note:** The version of `paging-mpp` still needs updating once cashapp/multiplatform-paging#121 is in a release
hfhbd
added a commit
to cashapp/sqldelight
that referenced
this pull request
Jun 23, 2023
* Add linux and mingw x64 target to the paging extension **Note:** The version of `paging-mpp` still needs updating once cashapp/multiplatform-paging#121 is in a release * Use release version of paging-mpp * Replace sqlite static lib extraction with cinterop of the sqlite amalgamation --------- Co-authored-by: Philip Wedemann <22521688+hfhbd@users.noreply.github.com>
|
Just curios, what about linuxArm64 too? |
I plan to open a PR for that as well, but i had no way of testing it locally at the time i wrote this (and the sqldelight) PR. That's all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originating issue: cashapp/sqldelight#4272
This adds
linuxX64andmingwX64targets.