-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux and mingw x64 target to the paging extension #4280
Add linux and mingw x64 target to the paging extension #4280
Conversation
**Note:** The version of `paging-mpp` still needs updating once cashapp/multiplatform-paging#121 is in a release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 will merge once the paging lib is released
(and tests pass) |
@chippmann Your PR is part of |
The reason for the failing test seem to be an sqlite compiling error:
I saw that you have a static What was the reason to extract the sqlite lib from that ubuntu version and what do you think about using a sqlite amalgamation (https://www.sqlite.org/amalgamation.html) for the linux tests instead? That one could just be used with a One example would be (taken from one of my native projects using sqldelight on linuxX64):
|
@chippmann I copied the sqlite.a from 14.04 because this version was compiled with glibc 2.19, the same version used by Kotlin native compiler: #4040 (comment) If switching to the armageddon file works, I am open. |
Head branch was pushed to by a user without write access
@hfhbd Could you rerun the tests please (I do not have the necessary rights to do so). |
Resolves #4272
This adds the
linuxX64
andmingwX64
targets to the paging extension.Also the linking was done on each binary but is only necessary on the test binaries (as far as i can see). This PR only links the
sqlite
library if the binary is a test binary.Note:
The version of
paging-mpp
inlibs.versions.toml
still needs updating once cashapp/multiplatform-paging#121 is in a release.Until this has happened, this PR should probably remain a draft