Upgrade kotlin and idea version to fix kapt issue #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kpgalligan is tracking the kotlin 1.3.40 change, i think theres a little more involved here which is causing build to fail other changes lgtm, once kevin gets 1.3.40 in we can merge those as well |
ThomasCJY
force-pushed
the
jchen-upgradeKotlinAndIdea
branch
from
0d0f8c2
to
c547030
Compare
|
@AlecStrong My latest change fixed the build issues. Not sure whether there are other things which need to be taken care of. @kpgalligan mind take a look? |
|
fantastic. looks good to me. @kpgalligan gonna merge this but if theres stuff that was missed please let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#1336
Previously, the kotlin incremental annotation processing feature is broken once we integrated it with sqldelight.
Change