Add run configuration for sqlite #2718

aperfilyev · 2021-12-03T20:08:14Z

Would you be interested in something like this?

Screen.Recording.2021-12-03.at.23.04.40.mov

JakeWharton · 2021-12-04T01:36:51Z

AlecKazakova · 2021-12-04T04:05:27Z

What the fuck yes that’s amazing

AlecKazakova · 2021-12-04T04:06:54Z

if you’ll allow some nerd sniping this would be amazing if you could tell it to connect to a live db, like something on disk or running android app

aperfilyev · 2021-12-04T14:46:32Z

Yes I wanted to add a dialog to pick a database file. As for Android, what's the right way to do it? I might peek into database inspector in AS.

AlecKazakova · 2021-12-04T15:03:43Z

Will probably have to get creative, we can pull the database with adb, but I would look at the source for things like stetho or even android studio itself to see how they connect. Jake might have other ideas too. Ideally we integrate with the inspector as much as possible but tbh I kinda like the picnic output

…

On Sat, Dec 4, 2021 at 9:46 AM Alexander Perfilyev ***@***.***> wrote: Yes I wanted to add a dialog to pick a database file. As for Android, what's the right way to do it? I might peek into database inspector in AS. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2718 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMZBQDJT3Q6GLE2DX6T343UPISVFANCNFSM5JKQ3QLQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

aperfilyev · 2021-12-09T14:03:35Z

Untitled.mov

I've made integration with AS database inspector but it requires IJ 2021.3. Is there a way to depend both on Android Studio and Intellij?

AlecKazakova · 2021-12-09T15:27:03Z

WOW that is amazing. Is the problem that you need to compile against android SDKs for this to work?

aperfilyev · 2021-12-09T15:41:25Z

Yes, I have to specify either intellij.localPath=/path/to/Android Studio.app or intellij.version=2021.3 for it to compile

AlecKazakova · 2021-12-09T15:57:17Z

if you dont specify those which classes cant be found?

The thing I'm thinking is specifying a compileOnly dependency on the maven artifacts for 2021.3 APIs, and then wrapping the code in a if (ApplicationInfo.getInstance().getVersion() > 2021.3) { register everything }

The other alternatives are to ship separate plugins, which I think is what most folks do but sounds like a lot of work, or just wait until Android Studio stable is on 2021.3, it looks like the bumblebee beta is on 2021.1 so presumably the one after that will be 2021.3?

aperfilyev · 2021-12-09T17:21:22Z

if you dont specify those which classes cant be found?

it can't find new database inspector classes that are not present in ij-203.

The thing I'm thinking is specifying a compileOnly dependency on the maven artifacts for 2021.3 APIs, and then wrapping the code in a if (ApplicationInfo.getInstance().getVersion() > 2021.3) { register everything }

I'm not sure it will work because it throws a bunch of ClassNotFoundException if I specify android studio in runIde config. :/

it looks like the bumblebee beta is on 2021.1 so presumably the one after that will be 2021.3?

Chipmunk is on 2021.2, unfortunately

if you wanna play with it, you can check this commit aperfilyev@9a2e0ad

AlecKazakova · 2021-12-09T17:49:22Z

coolcool, i'll give that a shot

AlecKazakova · 2022-02-08T14:19:09Z

dolphin is 2021.3, I think we just wait for that to release and then merge this as is bumping our minimum intellij up, probably the easiest thing to do

aperfilyev · 2022-02-08T14:54:20Z

Yes, and I hope it doesn't take another year before it becomes stable. Should I send a pr?

AlecKazakova · 2022-02-08T14:59:06Z

id wait to update this until we're getting close to the next sqldelight release and depending on what stage dolphin is at we can merge it

JakeWharton · 2022-02-08T15:05:09Z

It's supposed to be 4 month cycles so June-ish.

AlecKazakova

Just an initial skim through of the high level stuff. I think these abstractions are the right direction, and theres probably small stuff we could do to extend them to other dialects+connection types.

AlecKazakova · 2022-04-18T19:44:01Z

sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/run/ConnectionManager.kt

+      throw SQLException("The file path is empty")
+    }
+
+    return DriverManager.getConnection("jdbc:sqlite:$filePath")


We should reuse this class for DatabaseFileViewProvider too, and steal its logic to make sure its loading from the correct plugin classloader #3080

AlecKazakova · 2022-04-18T19:45:53Z

sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/run/ConnectionManager.kt

+  }
+}
+
+internal class ConnectionManagerImpl(private val project: Project) : ConnectionManager {


It looks like this is actually the only thing thats dialect-specific. I don't know if its worth promoting into the dialect api but at least for testing we could try bundling like the postgres jdbc artifact and prompting the user for the connection url. Doesnt have to be in this PR, just spitballing

AlecKazakova · 2022-04-18T19:48:34Z

sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/run/RunSqlAction.kt

+  private val dialogFactory: ArgumentsInputDialog.Factory = ArgumentsInputDialogFactoryImpl()
+) : AnAction() {
+
+  override fun actionPerformed(e: AnActionEvent) {


I assume this would be visible along with the android studio action that we just merged in - the implementations are actually so similar it seems like this AnAction stuff might be able to just detect if android is around and use that to connect vs the custom jdbc stuff

AlecKazakova · 2022-04-18T19:50:05Z

...t-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/run/SelectConnectionTypeAction.kt

+  var connectionType: ConnectionType by connectionType(project)
+}
+
+internal class SelectConnectionTypeDialog(


okay and then this is the thing where it would be sweet if we could somehow find localhost ports that have a valid db running to connect to. If thats even possible we can probably just skim IntelliJ source code to find something that already does it, but again not for this PR

AlecKazakova · 2022-04-20T13:42:43Z

FYI I'm gonna play around on this branch and might push some stuff, but I'll do it as separate commits instead of force pushing so we don't step on each others toes

olme04 · 2022-04-20T13:57:39Z

This looks really awesome!
Will it be possible to somehow later integrate it with IDEA database plugin (https://www.jetbrains.com/help/idea/relational-databases.html, unfortunately it's available only in Ultimate) in similar way, as with android studio database inspector?

AlecKazakova · 2022-04-20T14:01:19Z

ideally yes, but because those APIs are likely closed source it might be impossible.

@aperfilyev 's trick for the AS Database inspector might also work here though, creating a fake .sql file that just delegates to the gutter action ultimate would create for that file. Worth trying at some point but no guarantees it will work

AlecKazakova · 2022-04-21T02:21:25Z

Okay here's where its at

Screen.Recording.2022-04-20.at.10.18.13.PM.mov

I'm pretty happy with this as a starting point. Some follow ups possible after this:

Implement the connection manager for Postgres/MySQL
Ability to delete connection
Ability to select no connection so the gutter icon disappears
Show the SQL that you ran in the run tab
Make it possible to just run raw sql against a connection

Will open this up for review then, I'll do a self review before merging but @aperfilyev might want to give things a look over too to make sure my changes make sense

sqldelight-idea-plugin/src/main/resources/META-INF/plugin.xml

JakeWharton

I did the best I could

...elight-compiler/dialect/src/main/kotlin/app/cash/sqldelight/dialect/api/SqlDelightDialect.kt

...ite-3-18/src/main/kotlin/app/cash/sqldelight/dialects/sqlite_3_18/SqliteConnectionManager.kt

sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/ProjectService.kt

JakeWharton · 2022-04-21T03:57:58Z

...ght-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/run/ArgumentsInputDialogImpl.kt

+  }
+
+  private val _result = mutableListOf<SqlParameter>()
+  override val result: List<SqlParameter> = _result


super nit:

Suggested change

override val result: List<SqlParameter> = _result

override val result: List<SqlParameter> get() = _result

avoid redundant backing property

aperfilyev · 2022-04-21T06:33:21Z

The code looks good but when I execute :runIde: I get this weird exception java.lang.AbstractMethodError: Receiver class app.cash.sqldelight.dialects.sqlite_3_18.SqliteDialect does not define or inherit an implementation of the resolved method 'abstract app.cash.sqldelight.dialect.api.ConnectionManager connectionManager()' of interface app.cash.sqldelight.dialect.api.SqlDelightDialect.
Maybe it's just me

upd: nevermind, it seems related to the specified dialect version

* Add run configuration for sqlite * Add some tests * Run spotless * Fix up code so it works with master * Remove need for an identifier * Reuse ConnectionManager in compiler module * Move the connection manager to the dialect API * Remove tests and run spotless * Simplify RunSqlAction * Update sqldelight-idea-plugin/src/main/resources/META-INF/plugin.xml * Address feedback Co-authored-by: Alec Strong <astrong@squareup.com> Co-authored-by: Alec Strong <AlecStrong@users.noreply.github.com>

aperfilyev force-pushed the aperfilyev/run-configuration branch from 884dbf2 to 1cfdaac Compare December 4, 2021 07:11

aperfilyev force-pushed the aperfilyev/run-configuration branch from 1cfdaac to 41f6396 Compare January 14, 2022 09:35

AlecKazakova force-pushed the master branch from 037974a to b662d0a Compare April 1, 2022 00:15

AlecKazakova reviewed Apr 18, 2022

View reviewed changes

aperfilyev added 2 commits April 20, 2022 09:40

Add run configuration for sqlite

95de86b

Add some tests

9cdb929

AlecKazakova force-pushed the aperfilyev/run-configuration branch from 5666ba1 to 9cdb929 Compare April 20, 2022 13:40

AlecKazakova changed the base branch from master to sql-psi-dev April 20, 2022 13:41

Run spotless

a1452f8

AlecKazakova and others added 3 commits April 20, 2022 10:01

Fix up code so it works with master

b9f01b6

Remove need for an identifier

04da182

Reuse ConnectionManager in compiler module

5b77c0a

Move the connection manager to the dialect API

506c311

AlecKazakova marked this pull request as ready for review April 21, 2022 02:21

AlecKazakova force-pushed the aperfilyev/run-configuration branch from cb7d557 to b136d5c Compare April 21, 2022 02:40

Remove tests and run spotless

7dfa704

AlecKazakova force-pushed the aperfilyev/run-configuration branch from b136d5c to 7dfa704 Compare April 21, 2022 02:40

Simplify RunSqlAction

7d716cb

AlecKazakova reviewed Apr 21, 2022

View reviewed changes

sqldelight-idea-plugin/src/main/resources/META-INF/plugin.xml Outdated Show resolved Hide resolved

Update sqldelight-idea-plugin/src/main/resources/META-INF/plugin.xml

6328880

AlecKazakova approved these changes Apr 21, 2022

View reviewed changes

JakeWharton approved these changes Apr 21, 2022

View reviewed changes

Address feedback

7a15749

AlecKazakova merged commit 80e2799 into cashapp:sql-psi-dev Apr 21, 2022

aperfilyev deleted the aperfilyev/run-configuration branch April 21, 2022 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add run configuration for sqlite #2718

Add run configuration for sqlite #2718

aperfilyev commented Dec 3, 2021

JakeWharton commented Dec 4, 2021

AlecKazakova commented Dec 4, 2021

AlecKazakova commented Dec 4, 2021 •

edited

Loading

aperfilyev commented Dec 4, 2021

AlecKazakova commented Dec 4, 2021 via email

aperfilyev commented Dec 9, 2021

AlecKazakova commented Dec 9, 2021

aperfilyev commented Dec 9, 2021

AlecKazakova commented Dec 9, 2021

aperfilyev commented Dec 9, 2021

AlecKazakova commented Dec 9, 2021

AlecKazakova commented Feb 8, 2022

aperfilyev commented Feb 8, 2022

AlecKazakova commented Feb 8, 2022

JakeWharton commented Feb 8, 2022

AlecKazakova left a comment

AlecKazakova Apr 18, 2022

AlecKazakova Apr 18, 2022

AlecKazakova Apr 18, 2022

AlecKazakova Apr 18, 2022

AlecKazakova commented Apr 20, 2022

olme04 commented Apr 20, 2022

AlecKazakova commented Apr 20, 2022

AlecKazakova commented Apr 21, 2022

JakeWharton left a comment

JakeWharton Apr 21, 2022

aperfilyev commented Apr 21, 2022 •

edited

Loading

	override val result: List<SqlParameter> = _result
	override val result: List<SqlParameter> get() = _result

Add run configuration for sqlite #2718

Add run configuration for sqlite #2718

Conversation

aperfilyev commented Dec 3, 2021

JakeWharton commented Dec 4, 2021

AlecKazakova commented Dec 4, 2021

AlecKazakova commented Dec 4, 2021 • edited Loading

aperfilyev commented Dec 4, 2021

AlecKazakova commented Dec 4, 2021 via email

aperfilyev commented Dec 9, 2021

AlecKazakova commented Dec 9, 2021

aperfilyev commented Dec 9, 2021

AlecKazakova commented Dec 9, 2021

aperfilyev commented Dec 9, 2021

AlecKazakova commented Dec 9, 2021

AlecKazakova commented Feb 8, 2022

aperfilyev commented Feb 8, 2022

AlecKazakova commented Feb 8, 2022

JakeWharton commented Feb 8, 2022

AlecKazakova left a comment

Choose a reason for hiding this comment

AlecKazakova Apr 18, 2022

Choose a reason for hiding this comment

AlecKazakova Apr 18, 2022

Choose a reason for hiding this comment

AlecKazakova Apr 18, 2022

Choose a reason for hiding this comment

AlecKazakova Apr 18, 2022

Choose a reason for hiding this comment

AlecKazakova commented Apr 20, 2022

olme04 commented Apr 20, 2022

AlecKazakova commented Apr 20, 2022

AlecKazakova commented Apr 21, 2022

JakeWharton left a comment

Choose a reason for hiding this comment

JakeWharton Apr 21, 2022

Choose a reason for hiding this comment

aperfilyev commented Apr 21, 2022 • edited Loading

AlecKazakova commented Dec 4, 2021 •

edited

Loading

aperfilyev commented Apr 21, 2022 •

edited

Loading