-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle Verify Task: Throw when missing database file. #3126
Gradle Verify Task: Throw when missing database file. #3126
Conversation
@@ -118,7 +118,7 @@ class JavadocTest { | |||
) | |||
} | |||
|
|||
@Test fun `select - javadoc containing * symbols`(testDialect: TestDialect) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w: sqldelight/sqldelight-compiler/src/test/kotlin/app/cash/sqldelight/core/queries/JavadocTest.kt: (121, 13): Name contains characters which can cause problems on Windows: *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this task still exist and run if you do ./gradlew build
with no .db
files?
If so I don't think we should break, we should just not have the task.
But agreed if you specifically invoke this task and there are no dbs, it should fail
I assume the gradle plugin tests are failing in that scenario |
Yup that's also why the build is failing. It fails since in the sample there's no |
…migrations is turned on.
@AlecStrong should we do it like I've done now or should we stop adding the verify task altogether in case |
i like this. If the flag is on you should always have a .db file to verify them with. |
Fixes #2540