Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip unused adapters #3162

Merged
merged 2 commits into from
May 5, 2022
Merged

Skip unused adapters #3162

merged 2 commits into from
May 5, 2022

Conversation

eygraber
Copy link
Contributor

Fixes #3161

eygraber
eygraber commented Apr 27, 2022
View reviewed changes
sqldelight-compiler/src/main/kotlin/app/cash/sqldelight/core/compiler/DatabaseGenerator.kt
.flatMap { it.queryFiles() }
.flatMap { it.requiredAdapters }
Copy link
Contributor Author

@eygraber eygraber Apr 27, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlecStrong testing something out here because I can't figure out why the integration tests are failing.

In the current code, only the first SqlDelightQueriesFile is used. Is that a bug, or is everything concatted into one file?

@eygraber
Copy link
Contributor Author

Latest failure - https://github.com/cashapp/sqldelight/runs/6202856884?check_suite_focus=true#step:5:452

I got this error locally as well, and had to kill the gradle daemon and rerun.

@AlecKazakova AlecKazakova merged commit a5ed27d into cashapp:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlecKazakova AlecKazakova AlecKazakova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Parameter is never used" Warning When a Table that Requires an Adapter has No Functions Using the Adapter
2 participants
@eygraber @AlecKazakova