Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kpg/nmm native driver #3177

Merged
merged 15 commits into from
May 4, 2022
Merged

Kpg/nmm native driver #3177

merged 15 commits into from
May 4, 2022

Conversation

kpgalligan
Copy link
Collaborator

@kpgalligan kpgalligan commented May 3, 2022

Updated the native driver to use the new memory model. Strict memory model will still run, but some strict-specific implementations are not optimal. Moving to the new memory model is highly encouraged.

@AlecKazakova
Copy link
Collaborator

Is this just the code for updating the existing driver to be the strict-memory driver?

@AlecKazakova
Copy link
Collaborator

Oh I see, this will just work for both? Thats sick - this seems way simpler

@AlecKazakova
Copy link
Collaborator

all green, this ready to merge?

@kpgalligan
Copy link
Collaborator Author

Will work for both, but I want to change something. Working on it now. Will push in a bit.

@kpgalligan
Copy link
Collaborator Author

Had re-added some HMPP properties, but I see they've been added and removed previously. Last commit pulled them back out.

@kpgalligan kpgalligan marked this pull request as ready for review May 4, 2022 18:27
@AlecKazakova AlecKazakova merged commit d8f6581 into master May 4, 2022
@AlecKazakova AlecKazakova deleted the kpg/nmm-native-driver branch May 4, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants