Simplify the multiplatform configuration #3246
Conversation
| ":runtime:internal:publishJvmPublicationToInstallLocallyRepository", | ||
| ":runtime:internal:publishJsPublicationToInstallLocallyRepository", | ||
| ":runtime:shared:publishKotlinMultiplatformPublicationToInstallLocallyRepository", | ||
| ":runtime:shared:publishIosArm64PublicationToInstallLocallyRepository", |
There was a problem hiding this comment.
The changes in this file are unrelated and were required for some Gradle tests to pass on my mac. I'm assuming they pass on CI because they're run on linux and therefore the task are disabled.
There was a problem hiding this comment.
Oh well.. publishIosArm64PublicationToInstallLocallyRepository fails on linux. I reverted this part. Will look into it in a separate PR
…latform ios target'" This reverts commit 8491be2.
|
yea for now I think we just want stuff to go into commonMain and not worry about other source sets. We were essentially hardcoding it to commonMain anyways but in a more roundabout way so at least this is more explicit |
|
Hey! Would it be possible to cherry-pick these changes to 1.5.X ? |
With HMPP,
KotlinMetadataTargetnow has compilations for "shared" sourceSets. Our setup ended up with 2 tasks because we had an intermediateappleMainsource set. This PR hardcodes "commonMain" because well, I don't think the generated sources can end up in another sourceSet but maybe there's more to it?