Include PRAGMAs from migrations in database create(SqlDriver) #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate(SqlDriver) function PRAGMA statements defined in migrations, such as switching to WAL mode for SQLite, or toggling foreign keys, are executed as part of the migrate(SqlDriver, Int, Int) function, but are not executed as part of create(SqlDriver). They should be executed as part of both.
…SqlDriver) function
hfhbd
approved these changes
Jan 23, 2023
|
That makes sense, thanks. |
…abase create(SqlDriver) function
MariusVolkhart
deleted the
mv/includePragmaFromMigrationInDatabaseCreate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRAGMA statements defined in migrations, such as switching to WAL mode for SQLite, or toggling foreign keys, are executed as part of the migrate(SqlDriver, Int, Int) function, but are not executed as part of create(SqlDriver). They should be executed as part of both.
I suspect there may be a better way/location to write this test, and am happy to change it as requested.