Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose JsWorkerSqlCursor #3874

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Don't expose JsWorkerSqlCursor #3874

merged 1 commit into from
Feb 12, 2023

Conversation

hfhbd
Copy link
Collaborator

@hfhbd hfhbd commented Feb 12, 2023

Code gen and api use SqlCursor

Code gen and api uses `SqlCursor`
@hfhbd hfhbd requested a review from dellisd February 12, 2023 17:23
@hfhbd
Copy link
Collaborator Author

hfhbd commented Feb 12, 2023

@dellisd BTW which browser do you use for testing the driver? I am able to test it with Chrome but not Safari.

@dellisd
Copy link
Collaborator

dellisd commented Feb 12, 2023

The tests are currently only run on Chrome. In theory there shouldn't be anything stopping this from working on Safari (and other modern browsers), but I haven't checked.

@hfhbd
Copy link
Collaborator Author

hfhbd commented Feb 12, 2023

Okay, I tried your sample: https://github.com/dellisd/sqldelight-sqlite-wasm which works in chrome, but not in safari (I guess due to missing headers due GitHub pages), and locally it works with Chrome but I get a different error message on Safari :D Have to dig more to get it working in Safari too. But this should not affect sqldelight.

@hfhbd hfhbd merged commit 5500640 into master Feb 12, 2023
@hfhbd hfhbd deleted the hfhbd/patch-1-1 branch February 12, 2023 18:04
@dellisd
Copy link
Collaborator

dellisd commented Feb 12, 2023

Okay, I tried your sample: https://github.com/dellisd/sqldelight-sqlite-wasm which works in chrome, but not in safari (I guess due to missing headers due GitHub pages), and locally it works with Chrome but I get a different error message on Safari :D Have to dig more to get it working in Safari too. But this should not affect sqldelight.

If you can send me the error, or open an issue, I can take a look at it. My initial guess is that it's because Safari doesn't fully support the OPFS APIs that SQLite needs yet.

Either way I've been meaning to update the sample to use the more cross-browser compatible persistence method that the SQLite wasm build offers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants