Dont generate types for virtual tables #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfhbd
approved these changes
Mar 28, 2023
hfhbd
reviewed
Apr 5, 2023
| ) | ||
| } | ||
|
|
||
| public fun selectFromTable2(): Query<Myftstable2> = selectFromTable2 { something, nice -> |
There was a problem hiding this comment.
I struggle to understand this type. This is the type of the virtual table. According to the PR, this would not be generated. And with a clean build locally, this type isn't generated and results into a compiler error. Is this expected? If so, how does the CI pass?
There was a problem hiding this comment.
We should run the integration test twice, the first run generates (in-) valid code, the second run validates the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4001
You can still query/insert them, they just wont have table-specific types for them.
This enables using virtual tables with incompatible modules / columns that are never used from kotlin