Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore IDE runs of the compiler during an invalidated state #4016

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Ignore IDE runs of the compiler during an invalidated state #4016

merged 1 commit into from
Mar 28, 2023

Conversation

AlecKazakova
Copy link
Collaborator

Closes #3950

hfhbd
hfhbd approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@hfhbd hfhbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we somehow test it? Beside getting lesser issues

@AlecKazakova
Copy link
Collaborator Author

IDE issues like this not really, they happen in really rare race conditions. Sometimes IDE issues are super deterministic and we can add a plugin test but these days most of them are weird IDE internals

@AlecKazakova AlecKazakova merged commit 5da9ba2 into master Mar 28, 2023
@AlecKazakova AlecKazakova deleted the astrong/2023-03-28/ignore-invalid-runs-of-compiler branch March 28, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfhbd hfhbd hfhbd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

com.alecstrong.sql.psi.core.psi.InvalidElementDetectedException in NamedQuery.kt:200
2 participants
@AlecKazakova @hfhbd