Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated targets #4149

Merged
merged 3 commits into from
May 9, 2023
Merged

Remove deprecated targets #4149

merged 3 commits into from
May 9, 2023

Conversation

hfhbd
Copy link
Collaborator

@hfhbd hfhbd commented May 9, 2023

While it is technically not needed until 1.9.20, dropping these targets during 2.0.0 would be a major break, at least this is my understanding.

@hfhbd hfhbd changed the title remove deprecated targets Remove deprecated targets May 9, 2023
Copy link
Collaborator

@dellisd dellisd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these listed in the docs anywhere? Would be worth removing them as well if so.

@JakeWharton
Copy link
Member

@hfhbd
Copy link
Collaborator Author

hfhbd commented May 9, 2023

I guess @dellisd means our docs.

@hfhbd
Copy link
Collaborator Author

hfhbd commented May 9, 2023

I didn't find any docs containing native target support.

@hfhbd hfhbd enabled auto-merge (squash) May 9, 2023 16:31
@hfhbd hfhbd merged commit f901d2c into master May 9, 2023
@hfhbd hfhbd deleted the hfhbd/no-deprecated-targets branch May 9, 2023 17:00
hfhbd added a commit that referenced this pull request May 19, 2023
* remove deprecated targets

* Fix tests

* Fix tests

---------

Co-authored-by: hfhbd <hfhbd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants