Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postgreSql interval column result #4152

Merged
merged 4 commits into from
May 25, 2023
Merged

Add postgreSql interval column result #4152

merged 4 commits into from
May 25, 2023

Commits on May 12, 2023

  1. Add simple Interval tests 

    Bind arg test is easiest to debug
Add Integration test for PGInterval type
    @griffio
    griffio committed May 12, 2023
    Configuration menu
    Copy the full SHA
    be2db4f View commit details
    Browse the repository at this point in the history

  2. Add literal_value override 

    Override literal_value to support interval_expression
“INTERVAL ‘1 day” is the literal expression that will be used by the TypeResolver

This creates a new PostgresLiteralValue that inherits the base LiteralValueMixin

LiteralValueMixin may have to be customised to support returning CURRENT_DATE_TIME etc.
The base behaviour only allows assignments of timestamps.
    @griffio
    griffio committed May 12, 2023
    Configuration menu
    Copy the full SHA
    4cb9393 View commit details
    Browse the repository at this point in the history

  3. Add simple Interval type resolver 

    The SqlLiteralExpr will be “INTERVAL ‘1 day’”

Add CURRENT_  types to return actual types -ansi  inherited was TEXT

Calls the inherited “ansi” behaviour for NULL etc

There is probably a better way to achieve this in future PRs as there is more to do
    @griffio
    griffio committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a855d64 View commit details
    Browse the repository at this point in the history

  4. Test removed 

    Used for debug
    @griffio
    griffio committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e24960a View commit details
    Browse the repository at this point in the history