-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postgreSql Alter Column #4165
Add postgreSql Alter Column #4165
Conversation
Could you add an integration test? I guess, you still need to add a mixing to alter the schema. |
ed44e4f
to
8a31f93
Compare
ea05575
to
c0ccfea
Compare
Basic syntax for alter column. All changing types Identity columns Set and Drop NOT NULL ‘TYPE’ and ‘DATA’ are not in the inherited grammar
Permutions on alter column
Add another default
fix postgres version to support features in test postgres 9..6 is long unsupported
This was never enabled - perhaps due to failing test
This prevented the migration integration tests from running
c0ccfea
to
9db49c5
Compare
|
||
@Test fun integrationTestsPostgreSqlMigrations() { | ||
val runner = GradleRunner.create() | ||
.withCommonConfiguration(File("src/test/integration-postgresql-migrations")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o_O Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you.
@hfhbd can you re-trigger the build - without pushing another commit? thanks. Seems to be transient errors again 👺 as the build time is quite long ⏳
|
Sure, I restarted the job. |
Build runs fairly quickly locally 🏃 🐅 On GitHub the most recent change was to use Linux to run these tests (that should have improved build times?) - maybe try again ❔ |
closes #4163
Add the missing
ALTER [COLUMN]
support for PostgreSql with enough features to be useful in migration scripts.Extra 🗞️
Add into gradle build
src/test/integration-postgresql-migrations
- this was never enabled ❓Fix type that was preventing migrations test to run - possibly this was why 🦺
Add integration migration test for
alter table alter column
Add
AlterTableAlterColumnMixin
not sure what else it needs ❓