Gradle tweaks

[3flex]

Some Gradle plugin tweaks that can hopefully make it into 2.0 RC2.

[3flex]

I should note that KotlinBasePlugin was only added in Kotlin 1.7.0, so if compatibility with older versions is needed, this should be reverted.

https://kotlinlang.org/docs/whatsnew17.html#updates-in-the-kotlin-gradle-plugin-api

[hfhbd]

While I am fine with requiring Kotlin 1.7.0, could you split this change from the PR to merge the other Gradle plugin changes and we can discuss the Kotlin requirement in separate PR?

[AlecKazakova]

I think its fine, I can't imagine folks upgrading SQLDelight to not also be upgrading kotlin

[AlecKazakova]

Need to revert, this broke @shellderp 's build:

java.lang.NoClassDefFoundError: com/android/build/gradle/api/AndroidBasePlugin
        at app.cash.sqldelight.gradle.SqlDelightPlugin.apply(SqlDelightPlugin.kt:53)
        at app.cash.sqldelight.gradle.SqlDelightPlugin.apply(SqlDelightPlugin.kt:37)

[AlecKazakova]

(feel free to reopen the changes with a fix, the android plugin is optional on the classpath which is the issue)

[hfhbd]

Biggest question: Why did the tests success? Don't we have tests without AGP?

[AlecKazakova]

i thought so too, I'm not sure

i wonder if tests specifically are getting it transitively pulled in because of all the magic we do for shading

[hfhbd]

I took a look and I think, it is caused by this line:

sqldelight/sqldelight-gradle-plugin/src/test/buildscript.gradle

Line 14 in 4d2e8ff

classpath libs.android.plugin

I am already trying to fix the setup and getting failing tests.