Improve calling addListener #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfhbd
commented
Jun 7, 2023
| @@ -27,12 +27,12 @@ import app.cash.sqldelight.db.SqlDriver | |||
| @Suppress("FunctionName") // Emulating a constructor. | |||
| fun <RowType : Any> Query( | |||
| identifier: Int, | |||
| queryKeys: Array<String>, | |||
| vararg queryKeys: String, | |||
There was a problem hiding this comment.
Do we want to change this api too? This aligns with the addListener methods, but requires a lot of changes due to required named parameters.
|
Given that we've now pushed out a release candidate, the intent is to keep the API frozen. This is a breaking change so I think the ship has sailed on this for 2.0. Can this be added as an extension method instead? |
|
We don’t accept any breaking changes? We still do have some open issues marked with milestone 2.0 which will break the current api. |
|
If you change it to 
I'd keep it as |
|
It works, see #4244. fun test(vararg test: String, foo: Foo) |
|
Ah my bad, I named the parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4237
I also changed
queryKeys: Array<String>tovararg queryKeys: String, because I think, this api is nicer as developer.