Add automatic dialect support for Android API 34 #4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determined empirically:
$ adb shell getprop ro.build.version.sdk
34
$ adb shell sqlite3 --version
3.39.2 2022-07-21 15:24:47 698edb77537b67c41adc68f9b892db56bcf9a55e00371a61420f3ddd668e6603
JakeWharton
commented
Jun 9, 2023
Comment on lines
+33
to
+34
| // Mapping available at https://developer.android.com/reference/android/database/sqlite/package-summary. | ||
| if (minSdk >= 34) return "app.cash.sqldelight:sqlite-3-38-dialect:$VERSION" |
There was a problem hiding this comment.
Filed https://issuetracker.google.com/issues/286399699 to get the table updated for API 34.
hfhbd
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determined empirically: