-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stable output path for generated source #4269
Conversation
} else { | ||
generatedSourcesDirectory | ||
} | ||
private val Source.outputDir get() = File(generatedSourcesDirectory, name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why we did this and I already changed this in another locally branch too.
@joshfriend Please fix the merge conflicts to run the CI. |
9a0ae25
to
8c9abb4
Compare
This change would be nice to have backported to 1.x if possible, let me know if i can help with that somehow. |
The 1.x branch is the |
@dellisd Are you sure we still want to publish another 1.5.x release? |
(i have noticed the other test failures and am fixing them) |
Always include the variant name as part of output path Closes cashapp#4267
8c9abb4
to
cee2113
Compare
Always include the variant name as part of output path
Closes #4267