Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some docs for 2.0 #4438

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

AlecKazakova
Copy link
Collaborator

  • Schema version type changed to Long
  • Document optimistic locking
  • Remove the old upgrading docs
  • Fix the retrieved type information for mysql and postgres
  • Fix banner to link even from inner pages

@@ -1,5 +1,5 @@
{% extends "base.html" %}

{% block announce %}
SQLDelight 2.0 is now available! See <a href="upgrading-2.0">the docs</a> on migrating.
SQLDelight 2.0 is now available! See <a href="/sqldelight/upgrading-2.0">the docs</a> on migrating.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly, this won't work because our docs are versioned.

e.g. https://cashapp.github.io/sqldelight/**2.0.0-rc02**/upgrading-2.0

Let me check if there's a way to use the version macro in here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, couldn't get it to work.

I added a redirect in our gh-pages setup instead.

@AlecKazakova AlecKazakova force-pushed the astrong/2023-07-26/update-some-docs branch from 13757c5 to 7d19e6e Compare July 26, 2023 14:27
 - Schema version type changed to Long
 - Document optimistic locking
 - Remove the old upgrading docs
 - Fix the retrieved type information for mysql and postgres
 - Fix banner to link even from inner pages
@AlecKazakova AlecKazakova force-pushed the astrong/2023-07-26/update-some-docs branch from 7d19e6e to 4a41787 Compare July 26, 2023 14:28
@AlecKazakova AlecKazakova merged commit 26f794a into master Jul 26, 2023
6 checks passed
@AlecKazakova AlecKazakova deleted the astrong/2023-07-26/update-some-docs branch July 26, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants