Fix 4474 PostgreSql create extension #4541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support CREATE EXTENSION … ALTER EXTENSION ... DROP EXTENSION
Overrides the
extension_stmt
to add EXTENSION statementsfixes #4474
However, it doesn't solve the problem where sql extensions allow new functions and types as these are unknown to PostgreSqlTypeResolver (It's possible to extend a new local dialect see https://github.com/griffio/sqldelight-custom-dialect).
Currently, another work around is to use () around the function e.g
(uuid_generate_v4())
- the parser allows this for now as it's not strict enough.