Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostgreSql temporal types to SqlBinaryExpr #4657

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Add PostgreSql temporal types to SqlBinaryExpr #4657

merged 3 commits into from
Nov 16, 2023

Commits on Nov 15, 2023

  1. Update PostgreSqlTypeResolver temporal type 

    For encapsulatingType allow expressions to return temporal types
    PostgreSqlType.INTERVAL,
    PostgreSqlType.TIMESTAMP_TIMEZONE
    PostgreSqlType.TIMESTAMP

e.g 31 * INTERVAL '1 minute' + INTERVAL '2 days'

Timestamp should be ordered last

When binary expression contains TIMESTAMP and INTERVAL, TIMESTAMP must be selected
    @griffio
    griffio committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d22fd50 View commit details
    Browse the repository at this point in the history

  2. Add PostgreSql integration tests 

    Extend the existing tests with binary expressions
    @griffio
    griffio committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    764338d View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Change test to compare two intervals 

    Check that now + 1 is greater than now
    @griffio
    griffio committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d666bc2 View commit details
    Browse the repository at this point in the history